Add emit_extension_block_symbols for symbol graph extraction
#1195
+117
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
force-pushed
the
luis/add-support-for-emit-extension-block-symbols
branch
from
f3ca387
to
fada9f4
Compare
luispadron
force-pushed
the
luis/add-support-for-emit-extension-block-symbols
branch
2 times, most recently
from
712bb69
to
a5891b9
Compare
luispadron
changed the title
luispadron
changed the title
emit_extension_block_symbols for symbol graph extraction
luispadron
force-pushed
the
luis/add-support-for-emit-extension-block-symbols
branch
from
a5891b9
to
94e4693
Compare
|
@brentleyjones I've updated this for the new rule! Once we start integrating rules_swift 2.x into rules_apple I can close out bazelbuild/rules_apple#2445 |
luispadron
force-pushed
the
luis/add-support-for-emit-extension-block-symbols
branch
4 times, most recently
from
19b63b5
to
9779e03
Compare
The `emit_extension_block_symbols` attr can be used in the `swift_extract_symbol_graph` rule to pass the `-emit-extension-block-symbols` flag when creating the symbol graphs. This enables generating symbol graph information for extensions of custom types.
luispadron
force-pushed
the
luis/add-support-for-emit-extension-block-symbols
branch
from
9779e03
to
93a54ce
Compare
brentleyjones
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emit_extension_block_symbolsattr can be used in theswift_extract_symbol_graphrule to pass the-emit-extension-block-symbolsflag when creating the symbol graphs. This enables generating symbol graph information for extensions of custom types.This is required to support bazelbuild/rules_apple#2445